- I18n-commits - mailman.cloud.codelutin.com

r1921 - in trunk/maven-i18n-plugin/src: it/evo-1507 it/evo-1507/src/test/java/org/nuiton/i18n it/evo-1507/src/test/resources main/java/org/nuiton/i18n/plugin/bundle
by tchemit＠users.nuiton.org 11 May '11

11 May '11

Author: tchemit Date: 2011-05-11 16:48:59 +0200 (Wed, 11 May 2011) New Revision: 1921 Url: http://nuiton.org/repositories/revision/i18n/1921 Log: clean javadoc and it Modified: trunk/maven-i18n-plugin/src/it/evo-1507/invoker.properties trunk/maven-i18n-plugin/src/it/evo-1507/pom.xml trunk/maven-i18n-plugin/src/it/evo-1507/src/test/java/org/nuiton/i18n/ReadMessageFormatTest.java trunk/maven-i18n-plugin/src/it/evo-1507/src/test/resources/log4j.properties trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/BundleFormatConverter.java trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatConverter.java Modified: trunk/maven-i18n-plugin/src/it/evo-1507/invoker.properties =================================================================== --- trunk/maven-i18n-plugin/src/it/evo-1507/invoker.properties 2011-05-10 22:16:27 UTC (rev 1920) +++ trunk/maven-i18n-plugin/src/it/evo-1507/invoker.properties 2011-05-11 14:48:59 UTC (rev 1921) @@ -24,7 +24,7 @@ ### # A comma or space separated list of goals/phases to execute, may # specify an empty list to execute the default goal of the IT project -invoker.goals=clean test i18n:available-converters +invoker.goals=clean test # Optionally, a list of goals to run during further invocations of Maven #invoker.goals.2=${project.groupId}:${project.artifactId}:${project.version}:run Modified: trunk/maven-i18n-plugin/src/it/evo-1507/pom.xml =================================================================== --- trunk/maven-i18n-plugin/src/it/evo-1507/pom.xml 2011-05-10 22:16:27 UTC (rev 1920) +++ trunk/maven-i18n-plugin/src/it/evo-1507/pom.xml 2011-05-11 14:48:59 UTC (rev 1921) @@ -41,9 +41,9 @@ </parent> <groupId>org.nuiton.i18n</groupId> - <artifactId>evo-formatter</artifactId> + <artifactId>evo-1507</artifactId> - <name>I18n Test :: evo-formatter</name> + <name>I18n Test :: evo-1507</name> <dependencies> @@ -78,7 +78,6 @@ <verbose>true</verbose> <bundleFormatConverter>toMessageFormat</bundleFormatConverter> <bundleOutputName>ResultBundle</bundleOutputName> - <bundleOutputPackage>org.nuiton</bundleOutputPackage> </configuration> <executions> <execution> Modified: trunk/maven-i18n-plugin/src/it/evo-1507/src/test/java/org/nuiton/i18n/ReadMessageFormatTest.java =================================================================== --- trunk/maven-i18n-plugin/src/it/evo-1507/src/test/java/org/nuiton/i18n/ReadMessageFormatTest.java 2011-05-10 22:16:27 UTC (rev 1920) +++ trunk/maven-i18n-plugin/src/it/evo-1507/src/test/java/org/nuiton/i18n/ReadMessageFormatTest.java 2011-05-11 14:48:59 UTC (rev 1921) @@ -28,6 +28,7 @@ import org.junit.Assert; import org.junit.Test; import org.nuiton.i18n.init.DefaultI18nInitializer; +import org.nuiton.i18n.init.I18nInitializer; import java.util.Locale; @@ -42,19 +43,18 @@ @After public void tearDown() { I18n.close(); - I18n.setFormatter(I18nFormat.STRING_FORMAT); } @Test public void testMessageFormatFormatter() { - DefaultI18nInitializer initializer = - new DefaultI18nInitializer("ResultBundle", null, "org/nuiton/"); + I18nInitializer initializer = new DefaultI18nInitializer("ResultBundle"); + initializer.setMessageFormatter( + new I18nUtil.MessageFormatI18nMessageFormatter()); + I18n.init(initializer, Locale.FRANCE); - I18n.setFormatter(I18nFormat.MESSAGE_FORMAT); - String expected = "Message qui fait attention à la conversion de param"; String actual = I18n._("lib.property.message2", "param"); Assert.assertEquals(expected, actual); Modified: trunk/maven-i18n-plugin/src/it/evo-1507/src/test/resources/log4j.properties =================================================================== --- trunk/maven-i18n-plugin/src/it/evo-1507/src/test/resources/log4j.properties 2011-05-10 22:16:27 UTC (rev 1920) +++ trunk/maven-i18n-plugin/src/it/evo-1507/src/test/resources/log4j.properties 2011-05-11 14:48:59 UTC (rev 1921) @@ -30,5 +30,4 @@ log4j.appender.stdout.layout.ConversionPattern=%5p [%t] (%F:%L) %M - %m%n # package level -log4j.logger.org.nuiton.util=WARN -log4j.logger.org.nuiton.i18n=DEBUG +log4j.logger.org.nuiton=WARN Modified: trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/BundleFormatConverter.java =================================================================== --- trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/BundleFormatConverter.java 2011-05-10 22:16:27 UTC (rev 1920) +++ trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/BundleFormatConverter.java 2011-05-11 14:48:59 UTC (rev 1921) @@ -24,11 +24,10 @@ */ package org.nuiton.i18n.plugin.bundle; -import org.nuiton.i18n.I18nFormatter; - /** - * Used to convert from a {@link I18nFormatter} syntax to an other. + * Contract to make a conversion from a syntax to another one. * + * * Created: 05/05/11 * * @author fdesbois <desbois(a)codelutin.com> @@ -40,7 +39,7 @@ /** * Convert format syntax to an other from {@code value}. * - * @param value Message with some format placeholders to convert + * @param value message with some format placeholders to convert * @return the message with other format syntax */ String convert(String value); Modified: trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatConverter.java =================================================================== --- trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatConverter.java 2011-05-10 22:16:27 UTC (rev 1920) +++ trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatConverter.java 2011-05-11 14:48:59 UTC (rev 1921) @@ -29,11 +29,13 @@ import org.apache.commons.logging.LogFactory; import java.text.MessageFormat; +import java.util.Formatter; import java.util.regex.Matcher; import java.util.regex.Pattern; /** - * Converter used to change printf args syntax by {@link MessageFormat} syntax. + * Implementation of {@link BundleFormatConverter} to convert {@link Formatter} + * syntax to a {@link MessageFormat} syntax. * * Created: 05/05/11 *

1 0

r1920 - trunk
by tchemit＠users.nuiton.org 10 May '11

10 May '11

Author: tchemit Date: 2011-05-11 00:16:27 +0200 (Wed, 11 May 2011) New Revision: 1920 Url: http://nuiton.org/repositories/revision/i18n/1920 Log: Evolution #1516: Updates to m-helper-p 1.3 Modified: trunk/pom.xml Modified: trunk/pom.xml =================================================================== --- trunk/pom.xml 2011-05-10 20:39:58 UTC (rev 1919) +++ trunk/pom.xml 2011-05-10 22:16:27 UTC (rev 1920) @@ -188,7 +188,7 @@ <projectId>i18n</projectId> <processorVersion>1.2.1</processorVersion> - <helperPluginVersion>1.3-SNAPSHOT</helperPluginVersion> + <helperPluginVersion>1.3</helperPluginVersion>  <locales>fr,en</locales>

1 0

r1919 - in trunk/maven-i18n-plugin/src: it it/evo-1507 main/java/org/nuiton/i18n/plugin/bundle
by fdesbois＠users.nuiton.org 10 May '11

10 May '11

Author: fdesbois Date: 2011-05-10 22:39:58 +0200 (Tue, 10 May 2011) New Revision: 1919 Url: http://nuiton.org/repositories/revision/i18n/1919 Log: #1515 : Add AvailableConverterMojo for BundlerFormatConverter Added: trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/AvailableConverterMojo.java Modified: trunk/maven-i18n-plugin/src/it/evo-1507/README.txt trunk/maven-i18n-plugin/src/it/evo-1507/invoker.properties trunk/maven-i18n-plugin/src/it/settings.xml Modified: trunk/maven-i18n-plugin/src/it/evo-1507/README.txt =================================================================== --- trunk/maven-i18n-plugin/src/it/evo-1507/README.txt 2011-05-10 20:36:43 UTC (rev 1918) +++ trunk/maven-i18n-plugin/src/it/evo-1507/README.txt 2011-05-10 20:39:58 UTC (rev 1919) @@ -1,5 +1,5 @@ This it test the http://nuiton.org/issues/show/1507. -To test I18nFormatterMessageFormat and conversion from string.format syntax +To test BundlerFormatConverter and conversion from string.format syntax using StringFormatToMessageFormat. Modified: trunk/maven-i18n-plugin/src/it/evo-1507/invoker.properties =================================================================== --- trunk/maven-i18n-plugin/src/it/evo-1507/invoker.properties 2011-05-10 20:36:43 UTC (rev 1918) +++ trunk/maven-i18n-plugin/src/it/evo-1507/invoker.properties 2011-05-10 20:39:58 UTC (rev 1919) @@ -24,7 +24,7 @@ ### # A comma or space separated list of goals/phases to execute, may # specify an empty list to execute the default goal of the IT project -invoker.goals=clean test +invoker.goals=clean test i18n:available-converters # Optionally, a list of goals to run during further invocations of Maven #invoker.goals.2=${project.groupId}:${project.artifactId}:${project.version}:run Modified: trunk/maven-i18n-plugin/src/it/settings.xml =================================================================== --- trunk/maven-i18n-plugin/src/it/settings.xml 2011-05-10 20:36:43 UTC (rev 1918) +++ trunk/maven-i18n-plugin/src/it/settings.xml 2011-05-10 20:39:58 UTC (rev 1919) @@ -58,4 +58,9 @@ </pluginRepositories> </profile> </profiles> + + <pluginGroups> + <pluginGroup>org.nuiton.i18n</pluginGroup> + </pluginGroups> + </settings> Added: trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/AvailableConverterMojo.java =================================================================== --- trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/AvailableConverterMojo.java (rev 0) +++ trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/AvailableConverterMojo.java 2011-05-10 20:39:58 UTC (rev 1919) @@ -0,0 +1,79 @@ +/* + * #%L + * I18n :: Maven Plugin + * + * $Id$ + * $HeadURL$ + * %% + * Copyright (C) 2007 - 2011 CodeLutin + * %% + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as + * published by the Free Software Foundation, either version 3 of the + * License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Lesser Public License for more details. + * + * You should have received a copy of the GNU General Lesser Public + * License along with this program. If not, see + * <http://www.gnu.org/licenses/lgpl-3.0.html>. + * #L% + */ +package org.nuiton.i18n.plugin.bundle; + +import org.nuiton.plugin.AbstractAvailableDataMojo; + +import java.util.Arrays; +import java.util.Collection; +import java.util.Map; + +/** + * Mojo used to display available {@link BundleFormatConverter}. + * + * Created: 09/05/11 + * + * @author fdesbois <desbois(a)codelutin.com> + * $Id$ + * @goal available-converters + * @requiresProject true + * @requiresDirectInvocation true + * @requiresDependencyResolution test + * @since 2.4 + */ +public class AvailableConverterMojo extends AbstractAvailableDataMojo { + + /** + * Map of all availables {@link BundleFormatConverter}. + * + * @component role="org.nuiton.i18n.plugin.bundle.BundleFormatConverter" + */ + protected Map<String, BundleFormatConverter> bundleFormatConverters; + + @Override + protected Collection<AvailableData> getAllAvailableDatas() { + + AvailableData data = new AvailableData() { + + @Override + public String name() { + return "bundleFormatConverter"; + } + + @Override + public Map<String, ?> getData() { + return bundleFormatConverters; + } + + @Override + public String toString(Object value) { + return value.getClass().getName(); + } + }; + + return Arrays.asList(data); + } + +} Property changes on: trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/AvailableConverterMojo.java ___________________________________________________________________ Added: svn:keywords + Author Date Id Revision HeadURL

1 0

r1918 - in trunk/maven-i18n-plugin/src: main/java/org/nuiton/i18n/plugin/bundle test/java/org/nuiton/i18n/plugin/bundle
by fdesbois＠users.nuiton.org 10 May '11

10 May '11

Author: fdesbois Date: 2011-05-10 22:36:43 +0200 (Tue, 10 May 2011) New Revision: 1918 Url: http://nuiton.org/repositories/revision/i18n/1918 Log: Rename converter and remove previous commented implementation Added: trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatConverter.java trunk/maven-i18n-plugin/src/test/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatConverterTest.java Removed: trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormat.java trunk/maven-i18n-plugin/src/test/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatTest.java Deleted: trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormat.java =================================================================== --- trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormat.java 2011-05-10 20:16:51 UTC (rev 1917) +++ trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormat.java 2011-05-10 20:36:43 UTC (rev 1918) @@ -1,150 +0,0 @@ -/* - * #%L - * I18n :: Maven Plugin - * - * $Id$ - * $HeadURL$ - * %% - * Copyright (C) 2007 - 2011 CodeLutin, Tony chemit - * %% - * This program is free software: you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as - * published by the Free Software Foundation, either version 3 of the - * License, or (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Lesser Public License for more details. - * - * You should have received a copy of the GNU General Lesser Public - * License along with this program. If not, see - * <http://www.gnu.org/licenses/lgpl-3.0.html>. - * #L% - */ -package org.nuiton.i18n.plugin.bundle; - -import org.apache.commons.lang.StringUtils; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; - -import java.text.MessageFormat; -import java.util.regex.Matcher; -import java.util.regex.Pattern; - -/** - * Converter used to change printf args syntax by {@link MessageFormat} syntax. - * - * Created: 05/05/11 - * - * @author fdesbois <desbois(a)codelutin.com> - * @author tchemit <chemit(a)codelutin.com> - * @plexus.component role="org.nuiton.i18n.plugin.bundle.BundleFormatConverter" role-hint="toMessageFormat" - * @since 2.4 - */ -public class StringFormatToMessageFormat implements BundleFormatConverter { - - private static final Log log = - LogFactory.getLog(StringFormatToMessageFormat.class); - - protected static Pattern PATTERN = Pattern.compile("%\\$?(\\d?)[^\\s']*"); - - @Override - public String convert(String value) { - - String result; - - Matcher matcher = PATTERN.matcher(value); - boolean matches = matcher.find(); - - if (log.isDebugEnabled()) { - log.debug("> value : " + value + " _ matches ? " + matches); - } - - if (matches) { - - // Reset done, because of first find() - matcher.reset(); - - StringBuffer sb = new StringBuffer(); - int i = 0; - - while (matcher.find()) { - - if (log.isDebugEnabled()) { - log.debug("> match group : " + matcher.group(0)); - log.debug("> match group for number : " + matcher.group(1)); - } - - String argNumber = matcher.group(1); - - int nb; - - if (StringUtils.isNotEmpty(argNumber)) { - - // there is a arg position number, so must use the -1 value - nb = Integer.parseInt(argNumber) - 1; - } else { - - // use the current argument position value - nb = i; - } - -// int nb = i; -// // Group 1 is the arg number, for MessageFormat it starts from 0 -// // compare to printf that starts from 1 -// if (!"".equals(matcher.group(1))) { -// nb = Integer.parseInt(matcher.group(1)) - 1; -// } - - // Append replacement for current occurence - matcher.appendReplacement(sb, "\\{" + nb + "\\}"); - i++; - } - // Append last chars from input String - matcher.appendTail(sb); - result = sb.toString(); - - if (log.isDebugEnabled()) { - log.debug("Result : " + result); - } - -// result = escapeQuoteChar(result); - - } else { - - // there is no argument in incoming string value - result = value; - } - - result = escapeQuoteChar(result); - - return result; - } - - /** - * Escape ' char with '', needed by {@link MessageFormat}. - * - * @param value Message that contains ' - * @return the message with ' escaped - */ - protected String escapeQuoteChar(String value) { - - // Replace ' by '' - String result = value.replaceAll("'", "''"); -// String result = value.replaceAll("([^'])'([^'])", "$1''$2"); - - // Manage ' as last char -// result = result.replaceFirst("([^'])'$", "$1''"); - - // Manage ' as first char -// result = result.replaceFirst("^'([^'])", "''$1"); - - if (log.isDebugEnabled()) { - log.debug("Result with ' escape : " + result); - } - - return result; - } - -} Copied: trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatConverter.java (from rev 1915, trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormat.java) =================================================================== --- trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatConverter.java (rev 0) +++ trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatConverter.java 2011-05-10 20:36:43 UTC (rev 1918) @@ -0,0 +1,135 @@ +/* + * #%L + * I18n :: Maven Plugin + * + * $Id$ + * $HeadURL$ + * %% + * Copyright (C) 2007 - 2011 CodeLutin, Tony chemit + * %% + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as + * published by the Free Software Foundation, either version 3 of the + * License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Lesser Public License for more details. + * + * You should have received a copy of the GNU General Lesser Public + * License along with this program. If not, see + * <http://www.gnu.org/licenses/lgpl-3.0.html>. + * #L% + */ +package org.nuiton.i18n.plugin.bundle; + +import org.apache.commons.lang.StringUtils; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; + +import java.text.MessageFormat; +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +/** + * Converter used to change printf args syntax by {@link MessageFormat} syntax. + * + * Created: 05/05/11 + * + * @author fdesbois <desbois(a)codelutin.com> + * @author tchemit <chemit(a)codelutin.com> + * @plexus.component role="org.nuiton.i18n.plugin.bundle.BundleFormatConverter" role-hint="toMessageFormat" + * @since 2.4 + */ +public class StringFormatToMessageFormatConverter implements BundleFormatConverter { + + private static final Log log = + LogFactory.getLog(StringFormatToMessageFormatConverter.class); + + protected static Pattern PATTERN = Pattern.compile("%\\$?(\\d?)[^\\s']*"); + + @Override + public String convert(String value) { + + String result; + + Matcher matcher = PATTERN.matcher(value); + boolean matches = matcher.find(); + + if (log.isDebugEnabled()) { + log.debug("> value : " + value + " _ matches ? " + matches); + } + + if (matches) { + + // Reset done, because of first find() + matcher.reset(); + + StringBuffer sb = new StringBuffer(); + int i = 0; + + while (matcher.find()) { + + if (log.isDebugEnabled()) { + log.debug("> match group : " + matcher.group(0)); + log.debug("> match group for number : " + matcher.group(1)); + } + + String argNumber = matcher.group(1); + + int nb; + + if (StringUtils.isNotEmpty(argNumber)) { + + // there is a arg position number, so must use the -1 value + nb = Integer.parseInt(argNumber) - 1; + } else { + + // use the current argument position value + nb = i; + } + + // Append replacement for current occurence + matcher.appendReplacement(sb, "\\{" + nb + "\\}"); + i++; + } + // Append last chars from input String + matcher.appendTail(sb); + result = sb.toString(); + + if (log.isDebugEnabled()) { + log.debug("Result : " + result); + } + + } else { + + // there is no argument in incoming string value + result = value; + } + + // Always escape quote ' to '' + result = escapeQuoteChar(result); + + return result; + } + + /** + * Escape ' char with '', needed by {@link MessageFormat}. + * + * @param value Message that contains ' + * @return the message with ' escaped + */ + protected String escapeQuoteChar(String value) { + + // Replace ' by '' + String result = value.replaceAll("'", "''"); + + if (log.isDebugEnabled()) { + log.debug("Result with ' escape : " + result); + } + + return result; + } + +} Property changes on: trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatConverter.java ___________________________________________________________________ Added: svn:keywords + Author Date Id Revision HeadURL Added: svn:eol-style + native Copied: trunk/maven-i18n-plugin/src/test/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatConverterTest.java (from rev 1915, trunk/maven-i18n-plugin/src/test/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatTest.java) =================================================================== --- trunk/maven-i18n-plugin/src/test/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatConverterTest.java (rev 0) +++ trunk/maven-i18n-plugin/src/test/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatConverterTest.java 2011-05-10 20:36:43 UTC (rev 1918) @@ -0,0 +1,76 @@ +/* + * #%L + * I18n :: Maven Plugin + * + * $Id$ + * $HeadURL$ + * %% + * Copyright (C) 2007 - 2011 CodeLutin + * %% + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as + * published by the Free Software Foundation, either version 3 of the + * License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Lesser Public License for more details. + * + * You should have received a copy of the GNU General Lesser Public + * License along with this program. If not, see + * <http://www.gnu.org/licenses/lgpl-3.0.html>. + * #L% + */ +package org.nuiton.i18n.plugin.bundle; + +import org.junit.Assert; +import org.junit.Test; + +/** + * Tests the {@link StringFormatToMessageFormatConverter}. + * + * Created: 05/05/11 + * + * @author fdesbois <desbois(a)codelutin.com> + */ +public class StringFormatToMessageFormatConverterTest { + + BundleFormatConverter converter; + + @Test + public void testConvert() throws Exception { + + + converter = new StringFormatToMessageFormatConverter(); + + convertAndAssertEquals("Salut à tous pour l'ouverture", + "Salut à tous pour l''ouverture"); + + convertAndAssertEquals("Salut à tous pour l''ouverture", + "Salut à tous pour l''''ouverture"); + + convertAndAssertEquals("Salut à tous pour l'ouverture de %s", + "Salut à tous pour l''ouverture de {0}"); + + convertAndAssertEquals("Salut à tous pour l'ouverture de %$1s", + "Salut à tous pour l''ouverture de {0}"); + + convertAndAssertEquals("Salut à tous pour l'ouverture de %$2s le %$1t", + "Salut à tous pour l''ouverture de {1} le {0}" + ); + + convertAndAssertEquals( + "Salut à tous pour l'ouverture de %$2s le %$1td à l'heure %1tH", + "Salut à tous pour l''ouverture de {1} le {0} à l''heure {0}" + ); + + convertAndAssertEquals("Salut à tous pour l''ouverture de '%$1s'", + "Salut à tous pour l''''ouverture de ''{0}''"); + } + + protected void convertAndAssertEquals(String incoming, String expected) { + String actual = converter.convert(incoming); + Assert.assertEquals(expected, actual); + } +} Property changes on: trunk/maven-i18n-plugin/src/test/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatConverterTest.java ___________________________________________________________________ Added: svn:keywords + Author Date Id Revision HeadURL Added: svn:eol-style + native Deleted: trunk/maven-i18n-plugin/src/test/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatTest.java =================================================================== --- trunk/maven-i18n-plugin/src/test/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatTest.java 2011-05-10 20:16:51 UTC (rev 1917) +++ trunk/maven-i18n-plugin/src/test/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatTest.java 2011-05-10 20:36:43 UTC (rev 1918) @@ -1,97 +0,0 @@ -/* - * #%L - * I18n :: Maven Plugin - * - * $Id$ - * $HeadURL$ - * %% - * Copyright (C) 2007 - 2011 CodeLutin - * %% - * This program is free software: you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as - * published by the Free Software Foundation, either version 3 of the - * License, or (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Lesser Public License for more details. - * - * You should have received a copy of the GNU General Lesser Public - * License along with this program. If not, see - * <http://www.gnu.org/licenses/lgpl-3.0.html>. - * #L% - */ -package org.nuiton.i18n.plugin.bundle; - -import org.junit.Assert; -import org.junit.Test; - -/** - * Tests the {@link StringFormatToMessageFormat}. - * - * Created: 05/05/11 - * - * @author fdesbois <desbois(a)codelutin.com> - */ -public class StringFormatToMessageFormatTest { - - BundleFormatConverter converter; - - @Test - public void testConvert() throws Exception { - - - converter = new StringFormatToMessageFormat(); - -// String expected; -// String actual; - - convertAndAssertEquals("Salut à tous pour l'ouverture", - "Salut à tous pour l''ouverture"); - - convertAndAssertEquals("Salut à tous pour l''ouverture", - "Salut à tous pour l''''ouverture"); - -// actual = converter.convert("Salut à tous pour l'ouverture"); -// Assert.assertEquals(expected, actual); - - convertAndAssertEquals("Salut à tous pour l'ouverture de %s", - "Salut à tous pour l''ouverture de {0}"); -// expected = "Salut à tous pour l''ouverture de {0}"; -// actual = converter.convert("Salut à tous pour l'ouverture de %s"); -// Assert.assertEquals(expected, actual); - - convertAndAssertEquals("Salut à tous pour l'ouverture de %$1s", - "Salut à tous pour l''ouverture de {0}"); -// expected = "Salut à tous pour l''ouverture de {0}"; -// actual = converter.convert("Salut à tous pour l'ouverture de %$1s"); -// Assert.assertEquals(expected, actual); - - convertAndAssertEquals("Salut à tous pour l'ouverture de %$2s le %$1t", - "Salut à tous pour l''ouverture de {1} le {0}" - ); -// expected = "Salut à tous pour l''ouverture de {1} le {0}"; -// actual = converter.convert("Salut à tous pour l'ouverture de %$2s le %$1t"); -// Assert.assertEquals(expected, actual); - - convertAndAssertEquals( - "Salut à tous pour l'ouverture de %$2s le %$1td à l'heure %1tH", - "Salut à tous pour l''ouverture de {1} le {0} à l''heure {0}" - ); -// expected = "Salut à tous pour l''ouverture de {1} le {0} à l''heure {0}"; -// actual = converter.convert("Salut à tous pour l'ouverture de %$2s le %$1td à l'heure %1tH"); -// Assert.assertEquals(expected, actual); - - convertAndAssertEquals("Salut à tous pour l''ouverture de '%$1s'", - "Salut à tous pour l''''ouverture de ''{0}''"); -// expected = "Salut à tous pour l''ouverture de ''{0}''"; -// actual = converter.convert("Salut à tous pour l''ouverture de '%$1s'"); -// Assert.assertEquals(expected, actual); - } - - protected void convertAndAssertEquals(String incoming, String expected) { - String actual = converter.convert(incoming); - Assert.assertEquals(expected, actual); - } -}

1 0

r1917 - trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle
by tchemit＠users.nuiton.org 10 May '11

10 May '11

Author: tchemit Date: 2011-05-10 22:16:51 +0200 (Tue, 10 May 2011) New Revision: 1917 Url: http://nuiton.org/repositories/revision/i18n/1917 Log: Evolution #1513: Bundle mojo can have distinct encoding to read and write properties files Modified: trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/AbstractI18nBundleMojo.java trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/AbstractMakeI18nBundleMojo.java trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/BundleMojo.java Modified: trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/AbstractI18nBundleMojo.java =================================================================== --- trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/AbstractI18nBundleMojo.java 2011-05-10 20:11:19 UTC (rev 1916) +++ trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/AbstractI18nBundleMojo.java 2011-05-10 20:16:51 UTC (rev 1917) @@ -26,7 +26,6 @@ package org.nuiton.i18n.plugin.bundle; import org.nuiton.i18n.plugin.AbstractI18nMojo; -import org.nuiton.plugin.PluginHelper; import java.io.File; import java.io.IOException; @@ -91,16 +90,4 @@ return bundleOut; } - /** - * @param src the source file to read - * @return the url instanciated from lines of the source file. - * @throws IOException if any pb while reading file - * @deprecated since 1.2.2, use the {@link PluginHelper#getLinesAsURL(File)} - * instead. - */ - @Deprecated - public static URL[] getLinesAsURL(File src) throws IOException { - return PluginHelper.getLinesAsURL(src); - } - } Modified: trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/AbstractMakeI18nBundleMojo.java =================================================================== --- trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/AbstractMakeI18nBundleMojo.java 2011-05-10 20:11:19 UTC (rev 1916) +++ trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/AbstractMakeI18nBundleMojo.java 2011-05-10 20:16:51 UTC (rev 1917) @@ -44,6 +44,26 @@ public abstract class AbstractMakeI18nBundleMojo extends AbstractI18nBundleMojo { /** + * Encoding used to load any i18n property files. + * + * If not defined, will use the {@link #encoding} parameter. + * + * @parameter expression="${i18n.bundleInputEncoding}" + * @since 2.4 + */ + protected String bundleInputEncoding; + + /** + * Encoding used to write any i18n property files. + * + * If not defined, will use the {@link #encoding} parameter. + * + * @parameter expression="${i18n.bundleOutputEncoding}" + * @since 2.4 + */ + protected String bundleOutputEncoding; + + /** * Root directory where to generate aggregated bundles (this directory will * be added as resources of the project). * @@ -53,7 +73,6 @@ */ protected File bundleOutputDir; - /** * Package name of the generate aggregated bundles. * @@ -152,13 +171,34 @@ // get the definitive folder where to generate bundles (including // bundle package) - + outputFolder = getBundleOutputFolder(); if (isVerbose()) { getLog().info("Will generates bundles in " + outputFolder); } createDirectoryIfNecessary(outputFolder); + + if (StringUtils.isEmpty(bundleInputEncoding)) { + + // use the default encoding + bundleInputEncoding = getEncoding(); + if (getLog().isDebugEnabled()) { + getLog().debug("Use as input encoding the default one : " + + bundleInputEncoding); + } + } + + if (StringUtils.isEmpty(bundleOutputEncoding)) { + + // use the default encoding + bundleOutputEncoding = getEncoding(); + + if (getLog().isDebugEnabled()) { + getLog().debug("Use as output encoding the default one : " + + bundleOutputEncoding); + } + } } protected void failsIfWarning() throws MojoFailureException { @@ -235,4 +275,12 @@ return result; } + public String getBundleOutputEncoding() { + return bundleOutputEncoding; + } + + public String getBundleInputEncoding() { + return bundleInputEncoding; + } + } Modified: trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/BundleMojo.java =================================================================== --- trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/BundleMojo.java 2011-05-10 20:11:19 UTC (rev 1916) +++ trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/BundleMojo.java 2011-05-10 20:16:51 UTC (rev 1917) @@ -25,6 +25,8 @@ package org.nuiton.i18n.plugin.bundle; +import org.apache.commons.lang.StringUtils; +import org.apache.maven.plugin.MojoExecutionException; import org.nuiton.i18n.bundle.I18nBundleEntry; import org.nuiton.i18n.bundle.I18nBundleUtil; import org.nuiton.i18n.init.DefaultI18nInitializer; @@ -95,13 +97,31 @@ */ protected Map<String, BundleFormatConverter> bundleFormatConverters; + /** Format converter to apply if */ + protected BundleFormatConverter converter; + @Override public void init() throws Exception { super.init(); // add root bundle directory as resources of the project - + addResourceDir(bundleOutputDir, "**/*.properties"); + + if (StringUtils.isNotEmpty(bundleFormatConverter)) { + + // get converter from universe + converter = bundleFormatConverters.get(bundleFormatConverter); + + if (converter == null) { + + // unknown converter + throw new MojoExecutionException( + "There is no bundleFormatConverter named \"" + + bundleFormatConverter + "\", known ones are " + + bundleFormatConverters.keySet()); + } + } } @Override @@ -111,11 +131,18 @@ String version = getProject().getVersion(); version = PluginHelper.removeSnapshotSuffix(version); + String inputEncoding = getBundleInputEncoding(); + String outputEncoding = getBundleOutputEncoding(); + if (!silent) { getLog().info("config - resources dir : " + bundleOutputDir); getLog().info("config - package name : " + bundleOutputPackage); getLog().info("config - bundle name : " + bundleOutputName); - getLog().info("config - format converter : " + bundleFormatConverter); + getLog().info("config - input encoding : " + inputEncoding); + getLog().info("config - output encoding : " + outputEncoding); + if (bundleFormatConverter != null) { + getLog().info("config - format converter : " + bundleFormatConverter); + } getLog().info("config - locales : " + Arrays.toString(locales)); getLog().info("config - version : " + version); } @@ -134,7 +161,7 @@ ); SortedProperties propertiesOut = - new SortedProperties(encoding, false); + new SortedProperties(outputEncoding, false); StringBuilder buffer = new StringBuilder(); URL[] urls = getCollectI18nResources(locale); @@ -150,7 +177,7 @@ List<String> bundlesUrls = new ArrayList<String>(); - Charset loadEncoding = Charset.forName(encoding); + Charset loadEncoding = Charset.forName(inputEncoding); for (URL url : urls) { long t000 = System.nanoTime(); I18nBundleEntry bundleEntry = @@ -183,8 +210,8 @@ } // Apply conversion if necessary, depends on input bundleFormatConverter - if (bundleFormatConverter != null) { - applyConversion(propertiesOut, bundleFormatConverter); + if (converter != null) { + applyConversion(propertiesOut); } propertiesOut.store(bundleOut); @@ -258,20 +285,13 @@ } /** - * Apply conversion over {@code properties} with converter named - * {@code converterName}. + * Apply conversion over {@code properties} with internal converter. * * @param properties Properties to walk through - * @param converterName Name of the converter * @since 2.4 */ - protected void applyConversion(Properties properties, String converterName) { + protected void applyConversion(Properties properties) { - // Instantiate the converter - BundleFormatConverter converter = - bundleFormatConverters.get(converterName); - - // Apply conversion for (Entry<Object, Object> entry : properties.entrySet()) { String convertedValue = converter.convert((String) entry.getValue()); properties.setProperty((String) entry.getKey(), convertedValue);

1 0

r1916 - trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle
by tchemit＠users.nuiton.org 10 May '11

10 May '11

Author: tchemit Date: 2011-05-10 22:11:19 +0200 (Tue, 10 May 2011) New Revision: 1916 Url: http://nuiton.org/repositories/revision/i18n/1916 Log: Evolution #1512: Depreciates the tapestry-bundle mojo Modified: trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/TapestryBundleMojo.java Modified: trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/TapestryBundleMojo.java =================================================================== --- trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/TapestryBundleMojo.java 2011-05-10 13:52:04 UTC (rev 1915) +++ trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/TapestryBundleMojo.java 2011-05-10 20:11:19 UTC (rev 1916) @@ -53,7 +53,10 @@ * @requiresProject true * @requiresDependencyResolution runtime * @since 1.2 + * @deprecated since 2.4, will not be replaced, use the simple {@code bundle} + * goal instead */ +@Deprecated public class TapestryBundleMojo extends AbstractMakeI18nBundleMojo { @Override

1 0

r1915 - trunk/nuiton-i18n/src/main/java/org/nuiton/i18n
by fdesbois＠users.nuiton.org 10 May '11

10 May '11

Author: fdesbois Date: 2011-05-10 15:52:04 +0200 (Tue, 10 May 2011) New Revision: 1915 Url: http://nuiton.org/repositories/revision/i18n/1915 Log: Improve format case, MessageFormat must format all messages even there is no args Modified: trunk/nuiton-i18n/src/main/java/org/nuiton/i18n/I18n.java trunk/nuiton-i18n/src/main/java/org/nuiton/i18n/I18nFormat.java Modified: trunk/nuiton-i18n/src/main/java/org/nuiton/i18n/I18n.java =================================================================== --- trunk/nuiton-i18n/src/main/java/org/nuiton/i18n/I18n.java 2011-05-10 13:44:53 UTC (rev 1914) +++ trunk/nuiton-i18n/src/main/java/org/nuiton/i18n/I18n.java 2011-05-10 13:52:04 UTC (rev 1915) @@ -217,12 +217,14 @@ I18nLanguage language = getLanguage(locale); String result = language.translate(message); - if (args.length == 0) { + // Don't check the length, this will be done directly in formatter if necessary. + // In MessageFormat case it must format all messages even there is no args (because of '' escape case). +// if (args.length == 0) { +// +// // no argument form translation +// return applyFilter(result); +// } - // no argument form translation - return applyFilter(result); - } - try { return applyFilter(formatter.format(locale, result, args)); } catch (Exception eee) { Modified: trunk/nuiton-i18n/src/main/java/org/nuiton/i18n/I18nFormat.java =================================================================== --- trunk/nuiton-i18n/src/main/java/org/nuiton/i18n/I18nFormat.java 2011-05-10 13:44:53 UTC (rev 1914) +++ trunk/nuiton-i18n/src/main/java/org/nuiton/i18n/I18nFormat.java 2011-05-10 13:52:04 UTC (rev 1915) @@ -50,7 +50,14 @@ @Override public String format(Locale locale, String message, Object... args) { - return String.format(locale, message, args); + String result; + // Previous behavior, no format will be done for empty args + if (args.length == 0) { + result = message; + } else { + result = String.format(locale, message, args); + } + return result; } },

1 0

r1914 - trunk/nuiton-i18n/src/main/java/org/nuiton/i18n
by fdesbois＠users.nuiton.org 10 May '11

10 May '11

Author: fdesbois Date: 2011-05-10 15:44:53 +0200 (Tue, 10 May 2011) New Revision: 1914 Url: http://nuiton.org/repositories/revision/i18n/1914 Log: useless last ; Modified: trunk/nuiton-i18n/src/main/java/org/nuiton/i18n/I18nFormat.java Modified: trunk/nuiton-i18n/src/main/java/org/nuiton/i18n/I18nFormat.java =================================================================== --- trunk/nuiton-i18n/src/main/java/org/nuiton/i18n/I18nFormat.java 2011-05-10 11:16:26 UTC (rev 1913) +++ trunk/nuiton-i18n/src/main/java/org/nuiton/i18n/I18nFormat.java 2011-05-10 13:44:53 UTC (rev 1914) @@ -64,6 +64,6 @@ MessageFormat formatter = new MessageFormat(message, locale); return formatter.format(args); } - }; + } }

1 0

r1913 - in trunk: nuiton-i18n/src/main/java/org/nuiton/i18n nuiton-i18n/src/test/resources/META-INF src/site/apt src/site/en/apt
by tchemit＠users.nuiton.org 10 May '11

10 May '11

Author: tchemit Date: 2011-05-10 13:16:26 +0200 (Tue, 10 May 2011) New Revision: 1913 Url: http://nuiton.org/repositories/revision/i18n/1913 Log: add file header add svn properties Modified: trunk/nuiton-i18n/src/main/java/org/nuiton/i18n/I18nFormat.java trunk/nuiton-i18n/src/main/java/org/nuiton/i18n/I18nFormatter.java trunk/nuiton-i18n/src/test/resources/META-INF/I18nStoreTest_ja_JP.properties trunk/src/site/apt/gwt.apt trunk/src/site/en/apt/gwt.apt Modified: trunk/nuiton-i18n/src/main/java/org/nuiton/i18n/I18nFormat.java =================================================================== --- trunk/nuiton-i18n/src/main/java/org/nuiton/i18n/I18nFormat.java 2011-05-10 11:15:01 UTC (rev 1912) +++ trunk/nuiton-i18n/src/main/java/org/nuiton/i18n/I18nFormat.java 2011-05-10 11:16:26 UTC (rev 1913) @@ -1,3 +1,27 @@ +/* + * #%L + * I18n :: Api + * + * $Id$ + * $HeadURL$ + * %% + * Copyright (C) 2004 - 2011 CodeLutin + * %% + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as + * published by the Free Software Foundation, either version 3 of the + * License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Lesser Public License for more details. + * + * You should have received a copy of the GNU General Lesser Public + * License along with this program. If not, see + * <http://www.gnu.org/licenses/lgpl-3.0.html>. + * #L% + */ package org.nuiton.i18n; import java.text.MessageFormat; Property changes on: trunk/nuiton-i18n/src/main/java/org/nuiton/i18n/I18nFormat.java ___________________________________________________________________ Added: svn:eol-style + native Modified: trunk/nuiton-i18n/src/main/java/org/nuiton/i18n/I18nFormatter.java =================================================================== --- trunk/nuiton-i18n/src/main/java/org/nuiton/i18n/I18nFormatter.java 2011-05-10 11:15:01 UTC (rev 1912) +++ trunk/nuiton-i18n/src/main/java/org/nuiton/i18n/I18nFormatter.java 2011-05-10 11:16:26 UTC (rev 1913) @@ -1,3 +1,27 @@ +/* + * #%L + * I18n :: Api + * + * $Id$ + * $HeadURL$ + * %% + * Copyright (C) 2004 - 2011 CodeLutin + * %% + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as + * published by the Free Software Foundation, either version 3 of the + * License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Lesser Public License for more details. + * + * You should have received a copy of the GNU General Lesser Public + * License along with this program. If not, see + * <http://www.gnu.org/licenses/lgpl-3.0.html>. + * #L% + */ package org.nuiton.i18n; import java.util.Locale; Property changes on: trunk/nuiton-i18n/src/main/java/org/nuiton/i18n/I18nFormatter.java ___________________________________________________________________ Added: svn:eol-style + native Property changes on: trunk/nuiton-i18n/src/test/resources/META-INF/I18nStoreTest_ja_JP.properties ___________________________________________________________________ Added: svn:eol-style + native Modified: trunk/src/site/apt/gwt.apt =================================================================== --- trunk/src/site/apt/gwt.apt 2011-05-10 11:15:01 UTC (rev 1912) +++ trunk/src/site/apt/gwt.apt 2011-05-10 11:16:26 UTC (rev 1913) @@ -1,3 +1,27 @@ +~~~ +~~ #%L +~~ I18n +~~ +~~ $Id$ +~~ $HeadURL$ +~~ %% +~~ Copyright (C) 2008 - 2011 CodeLutin +~~ %% +~~ This program is free software: you can redistribute it and/or modify +~~ it under the terms of the GNU Lesser General Public License as +~~ published by the Free Software Foundation, either version 3 of the +~~ License, or (at your option) any later version. +~~ +~~ This program is distributed in the hope that it will be useful, +~~ but WITHOUT ANY WARRANTY; without even the implied warranty of +~~ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +~~ GNU General Lesser Public License for more details. +~~ +~~ You should have received a copy of the GNU General Lesser Public +~~ License along with this program. If not, see +~~ <http://www.gnu.org/licenses/lgpl-3.0.html>. +~~ #L% +~~~ GWT UiBinder et i18n, vous avez dit un cauchemard ? * GWT avec nuiton-i18n (et Maven) et ça coule de source Property changes on: trunk/src/site/apt/gwt.apt ___________________________________________________________________ Added: svn:eol-style + native Modified: trunk/src/site/en/apt/gwt.apt =================================================================== --- trunk/src/site/en/apt/gwt.apt 2011-05-10 11:15:01 UTC (rev 1912) +++ trunk/src/site/en/apt/gwt.apt 2011-05-10 11:16:26 UTC (rev 1913) @@ -1,3 +1,27 @@ +~~~ +~~ #%L +~~ I18n +~~ +~~ $Id$ +~~ $HeadURL$ +~~ %% +~~ Copyright (C) 2008 - 2011 CodeLutin +~~ %% +~~ This program is free software: you can redistribute it and/or modify +~~ it under the terms of the GNU Lesser General Public License as +~~ published by the Free Software Foundation, either version 3 of the +~~ License, or (at your option) any later version. +~~ +~~ This program is distributed in the hope that it will be useful, +~~ but WITHOUT ANY WARRANTY; without even the implied warranty of +~~ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +~~ GNU General Lesser Public License for more details. +~~ +~~ You should have received a copy of the GNU General Lesser Public +~~ License along with this program. If not, see +~~ <http://www.gnu.org/licenses/lgpl-3.0.html>. +~~ #L% +~~~ GWT UiBinder and i18n, you said nightmare ? * GWT with nuiton-i18n (and Maven) and it's easy Property changes on: trunk/src/site/en/apt/gwt.apt ___________________________________________________________________ Added: svn:eol-style + native

1 0

r1912 - in trunk/maven-i18n-plugin/src: main/java/org/nuiton/i18n/plugin/bundle test/java/org/nuiton/i18n/plugin/bundle
by tchemit＠users.nuiton.org 10 May '11

10 May '11

Author: tchemit Date: 2011-05-10 13:15:01 +0200 (Tue, 10 May 2011) New Revision: 1912 Url: http://nuiton.org/repositories/revision/i18n/1912 Log: improve converter from String.format to MessageFormat Modified: trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormat.java trunk/maven-i18n-plugin/src/test/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatTest.java Modified: trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormat.java =================================================================== --- trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormat.java 2011-05-10 10:35:33 UTC (rev 1911) +++ trunk/maven-i18n-plugin/src/main/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormat.java 2011-05-10 11:15:01 UTC (rev 1912) @@ -5,7 +5,7 @@ * $Id$ * $HeadURL$ * %% - * Copyright (C) 2007 - 2011 CodeLutin + * Copyright (C) 2007 - 2011 CodeLutin, Tony chemit * %% * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Lesser General Public License as @@ -24,26 +24,28 @@ */ package org.nuiton.i18n.plugin.bundle; +import org.apache.commons.lang.StringUtils; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; + import java.text.MessageFormat; import java.util.regex.Matcher; import java.util.regex.Pattern; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; - /** - * Converter used to change printf args syntax by {@link MessageFormat} syntax + * Converter used to change printf args syntax by {@link MessageFormat} syntax. * * Created: 05/05/11 * * @author fdesbois <desbois(a)codelutin.com> - * $Id$ + * @author tchemit <chemit(a)codelutin.com> * @plexus.component role="org.nuiton.i18n.plugin.bundle.BundleFormatConverter" role-hint="toMessageFormat" * @since 2.4 */ public class StringFormatToMessageFormat implements BundleFormatConverter { - private static final Log log = LogFactory.getLog(StringFormatToMessageFormat.class); + private static final Log log = + LogFactory.getLog(StringFormatToMessageFormat.class); protected static Pattern PATTERN = Pattern.compile("%\\$?(\\d?)[^\\s']*"); @@ -55,7 +57,9 @@ Matcher matcher = PATTERN.matcher(value); boolean matches = matcher.find(); - log.debug("> value : " + value + " _ matches ? " + matches); + if (log.isDebugEnabled()) { + log.debug("> value : " + value + " _ matches ? " + matches); + } if (matches) { @@ -63,33 +67,58 @@ matcher.reset(); StringBuffer sb = new StringBuffer(); - for (int i = 0; matcher.find(); i++) { + int i = 0; - log.debug("> match group : " + matcher.group(0)); - log.debug("> match group for number : " + matcher.group(1)); + while (matcher.find()) { - int nb = i; + if (log.isDebugEnabled()) { + log.debug("> match group : " + matcher.group(0)); + log.debug("> match group for number : " + matcher.group(1)); + } - // Group 1 is the arg number, for MessageFormat it starts from 0 - // compare to printf that starts from 1 - if (!"".equals(matcher.group(1))) { - nb = Integer.parseInt(matcher.group(1)) - 1; + String argNumber = matcher.group(1); + + int nb; + + if (StringUtils.isNotEmpty(argNumber)) { + + // there is a arg position number, so must use the -1 value + nb = Integer.parseInt(argNumber) - 1; + } else { + + // use the current argument position value + nb = i; } +// int nb = i; +// // Group 1 is the arg number, for MessageFormat it starts from 0 +// // compare to printf that starts from 1 +// if (!"".equals(matcher.group(1))) { +// nb = Integer.parseInt(matcher.group(1)) - 1; +// } + // Append replacement for current occurence matcher.appendReplacement(sb, "\\{" + nb + "\\}"); + i++; } // Append last chars from input String matcher.appendTail(sb); result = sb.toString(); - log.debug("Result : " + result); + if (log.isDebugEnabled()) { + log.debug("Result : " + result); + } - result = escapeQuoteChar(result); +// result = escapeQuoteChar(result); } else { + + // there is no argument in incoming string value result = value; } + + result = escapeQuoteChar(result); + return result; } @@ -102,15 +131,18 @@ protected String escapeQuoteChar(String value) { // Replace ' by '' - String result = value.replaceAll("([^'])'([^'])", "$1''$2"); + String result = value.replaceAll("'", "''"); +// String result = value.replaceAll("([^'])'([^'])", "$1''$2"); // Manage ' as last char - result = result.replaceFirst("([^'])'$", "$1''"); +// result = result.replaceFirst("([^'])'$", "$1''"); // Manage ' as first char - result = result.replaceFirst("^'([^'])", "''$1"); +// result = result.replaceFirst("^'([^'])", "''$1"); - log.debug("Result with ' escape : " + result); + if (log.isDebugEnabled()) { + log.debug("Result with ' escape : " + result); + } return result; } Modified: trunk/maven-i18n-plugin/src/test/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatTest.java =================================================================== --- trunk/maven-i18n-plugin/src/test/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatTest.java 2011-05-10 10:35:33 UTC (rev 1911) +++ trunk/maven-i18n-plugin/src/test/java/org/nuiton/i18n/plugin/bundle/StringFormatToMessageFormatTest.java 2011-05-10 11:15:01 UTC (rev 1912) @@ -28,41 +28,70 @@ import org.junit.Test; /** + * Tests the {@link StringFormatToMessageFormat}. + * * Created: 05/05/11 * * @author fdesbois <desbois(a)codelutin.com> - * $Id$ */ public class StringFormatToMessageFormatTest { + BundleFormatConverter converter; + @Test public void testConvert() throws Exception { - BundleFormatConverter converter = new StringFormatToMessageFormat(); - String expected = "Salut à tous pour l'ouverture"; - String actual = converter.convert("Salut à tous pour l'ouverture"); - Assert.assertEquals(expected, actual); + converter = new StringFormatToMessageFormat(); - expected = "Salut à tous pour l''ouverture de {0}"; - actual = converter.convert("Salut à tous pour l'ouverture de %s"); - Assert.assertEquals(expected, actual); +// String expected; +// String actual; - expected = "Salut à tous pour l''ouverture de {0}"; - actual = converter.convert("Salut à tous pour l'ouverture de %$1s"); - Assert.assertEquals(expected, actual); + convertAndAssertEquals("Salut à tous pour l'ouverture", + "Salut à tous pour l''ouverture"); - expected = "Salut à tous pour l''ouverture de {1} le {0}"; - actual = converter.convert("Salut à tous pour l'ouverture de %$2s le %$1t"); - Assert.assertEquals(expected, actual); + convertAndAssertEquals("Salut à tous pour l''ouverture", + "Salut à tous pour l''''ouverture"); - expected = "Salut à tous pour l''ouverture de {1} le {0} à l''heure {0}"; - actual = converter.convert("Salut à tous pour l'ouverture de %$2s le %$1td à l'heure %1tH"); - Assert.assertEquals(expected, actual); +// actual = converter.convert("Salut à tous pour l'ouverture"); +// Assert.assertEquals(expected, actual); - expected = "Salut à tous pour l''ouverture de ''{0}''"; - actual = converter.convert("Salut à tous pour l''ouverture de '%$1s'"); + convertAndAssertEquals("Salut à tous pour l'ouverture de %s", + "Salut à tous pour l''ouverture de {0}"); +// expected = "Salut à tous pour l''ouverture de {0}"; +// actual = converter.convert("Salut à tous pour l'ouverture de %s"); +// Assert.assertEquals(expected, actual); + + convertAndAssertEquals("Salut à tous pour l'ouverture de %$1s", + "Salut à tous pour l''ouverture de {0}"); +// expected = "Salut à tous pour l''ouverture de {0}"; +// actual = converter.convert("Salut à tous pour l'ouverture de %$1s"); +// Assert.assertEquals(expected, actual); + + convertAndAssertEquals("Salut à tous pour l'ouverture de %$2s le %$1t", + "Salut à tous pour l''ouverture de {1} le {0}" + ); +// expected = "Salut à tous pour l''ouverture de {1} le {0}"; +// actual = converter.convert("Salut à tous pour l'ouverture de %$2s le %$1t"); +// Assert.assertEquals(expected, actual); + + convertAndAssertEquals( + "Salut à tous pour l'ouverture de %$2s le %$1td à l'heure %1tH", + "Salut à tous pour l''ouverture de {1} le {0} à l''heure {0}" + ); +// expected = "Salut à tous pour l''ouverture de {1} le {0} à l''heure {0}"; +// actual = converter.convert("Salut à tous pour l'ouverture de %$2s le %$1td à l'heure %1tH"); +// Assert.assertEquals(expected, actual); + + convertAndAssertEquals("Salut à tous pour l''ouverture de '%$1s'", + "Salut à tous pour l''''ouverture de ''{0}''"); +// expected = "Salut à tous pour l''ouverture de ''{0}''"; +// actual = converter.convert("Salut à tous pour l''ouverture de '%$1s'"); +// Assert.assertEquals(expected, actual); + } + + protected void convertAndAssertEquals(String incoming, String expected) { + String actual = converter.convert(incoming); Assert.assertEquals(expected, actual); } - }

1 0