Author: tchemit Date: 2014-05-21 14:27:38 +0200 (Wed, 21 May 2014) New Revision: 1806 Url: http://forge.codelutin.com/projects/tutti/repository/revisions/1806 Log: fix tests Modified: trunk/tutti-service/src/test/java/fr/ifremer/tutti/service/export/generic/TuttiExportService2Test.java trunk/tutti-service/src/test/java/fr/ifremer/tutti/service/export/generic/TuttiExportServiceTest.java trunk/tutti-service/src/test/java/fr/ifremer/tutti/service/psionimport/PsionImportServiceTest.java Modified: trunk/tutti-service/src/test/java/fr/ifremer/tutti/service/export/generic/TuttiExportService2Test.java =================================================================== --- trunk/tutti-service/src/test/java/fr/ifremer/tutti/service/export/generic/TuttiExportService2Test.java 2014-05-21 11:10:13 UTC (rev 1805) +++ trunk/tutti-service/src/test/java/fr/ifremer/tutti/service/export/generic/TuttiExportService2Test.java 2014-05-21 12:27:38 UTC (rev 1806) @@ -130,7 +130,7 @@ URL url = new URL(urlPrefix + "species.csv"); ServiceDbResource.assertFileContent("species export:\n", url, - "Id;Code_Rubin;Nom_scientifique;Code_campagne\n" + + "Id;Code_Rubin;Nom_Scientifique;Code_campagne\n" + "380;ACANECH;Acanthocardia echinata;\n" + "1358;ALOSALO;Alosa alosa;\n" + "1938;AGONCAT;Agonus cataphractus;\n" + Modified: trunk/tutti-service/src/test/java/fr/ifremer/tutti/service/export/generic/TuttiExportServiceTest.java =================================================================== --- trunk/tutti-service/src/test/java/fr/ifremer/tutti/service/export/generic/TuttiExportServiceTest.java 2014-05-21 11:10:13 UTC (rev 1805) +++ trunk/tutti-service/src/test/java/fr/ifremer/tutti/service/export/generic/TuttiExportServiceTest.java 2014-05-21 12:27:38 UTC (rev 1806) @@ -165,13 +165,13 @@ "2013;Campagne CGFS;;GOV 19.7/25.9;A;1;1;100001;3835;Abalistes;;1425;4.0"; public static final String SPECIES_CONTENT = - "Id;Code_Rubin;Nom_scientifique;Code_campagne\n" + + "Id;Code_Rubin;Nom_Scientifique;Code_campagne\n" + "3835;ABAL;Abalistes;\n" + "11242;AAPT;Aaptos;\n" + "11243;AAPTAAP;Aaptos aaptos;"; public static final String SPECIES_CONTENT_2 = - "Id;Code_Rubin;Nom_scientifique;Code_campagne\n" + + "Id;Code_Rubin;Nom_Scientifique;Code_campagne\n" + "300;BUCCUND;Buccinum undatum;\n" + "365;AEQUOPE;Aequipecten opercularis;\n" + "489;LOLIVUL;Loligo vulgaris;LOLIVUL\n" + Modified: trunk/tutti-service/src/test/java/fr/ifremer/tutti/service/psionimport/PsionImportServiceTest.java =================================================================== --- trunk/tutti-service/src/test/java/fr/ifremer/tutti/service/psionimport/PsionImportServiceTest.java 2014-05-21 11:10:13 UTC (rev 1805) +++ trunk/tutti-service/src/test/java/fr/ifremer/tutti/service/psionimport/PsionImportServiceTest.java 2014-05-21 12:27:38 UTC (rev 1806) @@ -118,17 +118,8 @@ catchBatch.setFishingOperation(operation); BatchContainer<SpeciesBatch> rootSpeciesBatch = persistenceService.getRootSpeciesBatch(operation.getId(), false); - int oldSortedBatchs = 0; - int oldUnsortedBatchs = 0; for (SpeciesBatch speciesBatch : rootSpeciesBatch.getChildren()) { - - boolean sorted = vracPredicate.apply(speciesBatch); - - if (sorted) { - oldSortedBatchs++; - } else { - oldUnsortedBatchs++; - } + persistenceService.deleteSpeciesBatch(speciesBatch.getId()); } PsionImportResult importResult = service.importFile(importFile, operation, catchBatch); @@ -165,8 +156,8 @@ } } - Assert.assertEquals(oldSortedBatchs + nbNewSortedBatchs, totalSortedBatchs); - Assert.assertEquals(oldUnsortedBatchs + nbNewUnsortedBatchs, totalUnsortedBatchs); + Assert.assertEquals(nbNewSortedBatchs, totalSortedBatchs); + Assert.assertEquals(nbNewUnsortedBatchs, totalUnsortedBatchs); } @Test @@ -179,17 +170,8 @@ catchBatch.setFishingOperation(operation); BatchContainer<SpeciesBatch> rootSpeciesBatch = persistenceService.getRootSpeciesBatch(operation.getId(), false); - int oldSortedBatchs = 0; - int oldUnsortedBatchs = 0; for (SpeciesBatch speciesBatch : rootSpeciesBatch.getChildren()) { - - boolean sorted = vracPredicate.apply(speciesBatch); - - if (sorted) { - oldSortedBatchs++; - } else { - oldUnsortedBatchs++; - } + persistenceService.deleteSpeciesBatch(speciesBatch.getId()); } PsionImportResult importResult = service.importFile(importFile, operation, catchBatch); @@ -225,8 +207,8 @@ } } - Assert.assertEquals(oldSortedBatchs + nbNewSortedBatchs, totalSortedBatchs); - Assert.assertEquals(oldUnsortedBatchs + nbNewUnsortedBatchs, totalUnsortedBatchs); + Assert.assertEquals(nbNewSortedBatchs, totalSortedBatchs); + Assert.assertEquals(nbNewUnsortedBatchs, totalUnsortedBatchs); } @Test @@ -239,7 +221,10 @@ catchBatch.setFishingOperation(operation); BatchContainer<SpeciesBatch> rootSpeciesBatch = persistenceService.getRootSpeciesBatch(operation.getId(), false); - int oldNbBatchs = rootSpeciesBatch.sizeChildren(); + for (SpeciesBatch speciesBatch : rootSpeciesBatch.getChildren()) { + persistenceService.deleteSpeciesBatch(speciesBatch.getId()); + } + PsionImportResult importResult = service.importFile(importFile, operation, catchBatch); int nbSortedAdded = importResult.getNbSortedImported(); @@ -258,7 +243,7 @@ // no batch imported BatchContainer<SpeciesBatch> rootSpeciesBatchAfter = persistenceService.getRootSpeciesBatch(operation.getId(), false); - Assert.assertEquals(oldNbBatchs, rootSpeciesBatchAfter.sizeChildren()); + Assert.assertEquals(0, rootSpeciesBatchAfter.sizeChildren()); } @Test @@ -271,17 +256,8 @@ catchBatch.setFishingOperation(operation); BatchContainer<SpeciesBatch> rootSpeciesBatch = persistenceService.getRootSpeciesBatch(operation.getId(), false); - int oldSortedBatchs = 0; - int oldUnsortedBatchs = 0; for (SpeciesBatch speciesBatch : rootSpeciesBatch.getChildren()) { - - boolean sorted = vracPredicate.apply(speciesBatch); - - if (sorted) { - oldSortedBatchs++; - } else { - oldUnsortedBatchs++; - } + persistenceService.deleteSpeciesBatch(speciesBatch.getId()); } PsionImportResult importResult = service.importFile(importFile, operation, catchBatch); @@ -318,7 +294,7 @@ } } - Assert.assertEquals(oldSortedBatchs + nbNewSortedBatchs, totalSortedBatchs); - Assert.assertEquals(oldUnsortedBatchs + nbNewUnsortedBatchs, totalUnsortedBatchs); + Assert.assertEquals(nbNewSortedBatchs, totalSortedBatchs); + Assert.assertEquals(nbNewUnsortedBatchs, totalUnsortedBatchs); } }